[TF2] Add string support to game_round_win reason keyvalue #475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for direct strings to the
win_reasonkeyvalue ongame_round_win. This syntax is used in some TF2 Classic maps.Minor note: The
#ifdef TF_DLLis used at line 26 ofentity_roundwin.cppjust because that's how the enum is laid out; even though this entity is implied to be TF2-specific by its file location, it could theoretically be used by or ported to non-TF2 mods that use round-based gamerules.PR Checklist
developbranch OR targets another branch with a specific goal in mind